-
Notifications
You must be signed in to change notification settings - Fork 26
Add mechanism to remove published extensions #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aalves08
wants to merge
15
commits into
rancher:main
Choose a base branch
from
aalves08:13645-remove-from-publish-ext-not-on-manifest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add mechanism to remove published extensions #137
aalves08
wants to merge
15
commits into
rancher:main
from
aalves08:13645-remove-from-publish-ext-not-on-manifest
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create PR for extension sync: 2025-07-25-14-03-35
… go, after helm chart PR gets merged
… from docker hub repo and iterates to the next minor version
ing a release tag
…epository after the PR that updates the Helm Chart gets merged + update bundle-catalog script so that it outputs the tag generated for the extensions catalog so that it can be used in the release tag
9 tasks
…x.yaml if extensions are removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rancher/dashboard#13645
manifest.jsonmainbranch is always protected and it causes the workflow to fail (although it created the PR which is the important part)To test:
run this branch locally and do
./scripts/sync-charts/chartscalleddummy-ext, so that we can check the resilience of the script when a folder exists but no entries are found onmanifest.jsonelementalversion3.0.1-rc.2and check if the sync mechanism still works finemanifest.jsonto see the removal part in actionindex.yaml, especially after the removal of a given extension versionFixes rancher/dashboard#13717
extensions catalogautomatically after the PR to update the helm chart gets merged. It will get the "latest" version from the docker hub repo and bump the minor version so that we can keep all catalog images publishedextensions catalogjob is finished -> test done in https://github.com/aalves08/test-release-tag/actions/runs/17123969356/job/48571230902?pr=3 + https://github.com/aalves08/test-release-tag/releases/tag/v2.12.1NOTE: I can't really test the PR creation in it's full cycle because it's running from a fork, but I based my work on the recent rancher/dashboard#15655